close
Comments you submit will be routed for moderation. If you have an account, please log in first.
Modify

Opened 5 years ago

Closed 5 years ago

#111 closed enhancement (fixed)

Option to supress the filter requester.

Reported by: opiopi Owned by: opiopi
Priority: low Milestone: YAM 2.7
Component: user interface Version:
Severity: trivial Keywords:
Cc: OS Platform:
Blocked By: Blocking:
Release Notes:

Description

I would be nice if we could get a config option to supress the requester after a user has done a filter action.


Moved from SF:
https://sourceforge.net/tracker/?func=detail&aid=2895908&group_id=13560&atid=363560

Attachments (0)

Change History (10)

comment:1 Changed 5 years ago by damato

  • Component changed from stable build to undefined

comment:2 Changed 5 years ago by damato

  • Cc yamos-svn@… removed
  • Component changed from undefined to user interface
  • Milestone set to YAM 2.7
  • Priority changed from undecided to low
  • Reporter changed from opiopi@… to Opi
  • Severity changed from major to trivial
  • Status changed from new to accepted

This would be possible, but IMHO this should be first added as a hidden option so that we can see if some users really are using it and only bring it up as a real graphical user interface option in case it is widely requested.

comment:3 Changed 5 years ago by Opi

  • Owner set to Opi
  • Status changed from accepted to assigned

Hi

I do a patch which fulfill this request and attach the patch here.
Hope it will be committed ASAP by a developer with write access to
the SVN repository.

I Name the hidden option 'ShowMAFilterStats' because it could be
possible to add such option also for remote filters. So this
option should not clash with any possible future option.

BTW1: i doesn't like the hidden options at all. A better approach
would be a Advanced/Experts page in the config GUI. Maybe hidden
and visible if the enable it with a gadget.

BTW2: Maybe it's possible to get write access to the SVN repository?
Then i could add such small changes itself.

BTW3: Thanks for this great site. It's work a lot better as SF.net
in junction with AWeb. :-)

comment:4 Changed 5 years ago by damato

We do like your patch! However, we do have some minor things that need to be clarified:

  1. Why exactly did you name it "ShowMAFilterStats"? This is a very strange name. IMHO it should be simply named "ShowFilterStats" because there are no other filter statistics in YAM and I hardly doubt there will be one. In addition, we do not use the oldstyle "MA", "TR" namings anymore throughout the yam source code.
  2. Also the variable should simply be called "ShowFilterStats"

regarding your questions:

  1. I agree that an expert setting in the configuration would be great, but then this could be a lot of work and IMHO we should perhaps simply do something e.g. the mozilla project did with their hidden settings - provide a GUI based editor for the various options. That would serve the expert better IMHO.
  2. You are definitly welcome to join our project, however, unfortunately you have registered simply as "Opi". But as we still want to keep our usernames compatible to the old sf.net pages, please reregister with the same username you used at sf.net. Afterwards I can give you SVN write access.
  3. Thanks, we also love trac as it makes our development a lot easier ;)

comment:5 Changed 5 years ago by damato

  • Reporter changed from Opi to opiopi

comment:6 Changed 5 years ago by damato

  • Owner changed from Opi to opiopi

comment:7 Changed 5 years ago by damato

Ok, you should have SVN write access now. So welcome to the club! ;)

However, let us first clear things up as I listed above before you go and commit your changes. Also please read the STYLEGUIDE carefully and before comitting something I suggest that you first discuss these things with us on the devML at least for a while until you are used to the YAM sources, our way of doing things and so on ;)

So welcome aboard again.

comment:8 Changed 5 years ago by opiopi

  1. As i said before i named the variable like this because in

YAM is another filter requester for the remote filter.
See also YAM_TR.c -> TR_NewMailAlert(). The suggestion for the
name come from the name in the .cd file. I don't use such
remote fiter and the patch supress only the requester if a user
use the 'local filter' function. Because the chance for another
hidden option for supress such remote filter is low i ...

  1. renamed now all to 'ShowFilterStats'.

I thought i can get rid of my ugly username but it seems i can't :-(

Seems you delete the 'Opi' account because i can't log in as Opi.
So i can't replace the attached patch file. Please delete the file
as admin it should possible.

I'll try to commit the patch because you wrote you like the patch
and your suggestions are done.

For 'expert settings' we should open another ticket.

comment:9 Changed 5 years ago by damato

  1. Ok, but the functionality in TR_NewMailAlert() is like the name says, a "NewMailAlert". So a possible option for supressing that one would be "ShowNewMailAlert". However, such an option is not really necessary as hasRequesterNotify(C->NotifyType) suggests in TR_NewMailAlert(). Because a user can already suppress that window all together.
  1. Ok, fine

Ok, I deleted your attachment, feel free to submit a new one or commit the changes already to the SVN repository. But be warned that it may be reverted in case we still see something that have to be changed ;)

BTW: Please make sure to use a sensible checkin message and add the same message to the "ChangeLog" file in the root of our repository. This is always required. In addition, by adding something "This closes #XXX" with the ticket number this ticket will automatically closed as soon as you commit your changes. In addition, in case of a bug fix you can write "This fixes #XXX" and the ticket will be closed as well as fixed so that you don't have to manually close/acknowledge it afterwards.

comment:10 Changed 5 years ago by opiopi

  • Resolution set to fixed
  • Status changed from assigned to closed

implemented in revision 4592 (http://trac.yam.ch/changeset/4592)

Hope i did all correct.

The hint "This closes #XXX" came to late.
But thanks for the hint hope i remember about that next time...

Ok now i saw this option too. thanks also for this hint. :-)

Add Comment

Modify Ticket

Action
as closed The owner will remain opiopi.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.

This list contains all users that will be notified about changes made to this ticket.

These roles will be notified: Reporter, Owner, Subscriber

  • Frank Weber(Reporter, Owner, Participant)