close
Comments you submit will be routed for moderation. If you have an account, please log in first.
Modify

Opened 5 years ago

Closed 16 months ago

Last modified 12 months ago

#12 closed bug (fixed)

LISTFREEZE MAILS

Reported by: AmigaPhil Owned by: damato
Priority: undecided Milestone: YAM 2.9
Component: ARexx interface Version: 2.6
Severity: major Keywords:
Cc: OS Platform:
Blocked By: Blocking:
Release Notes:

fixed the LISTFREEZE and LISTUNFREEZE arexx commands to deal correctly with the Quiet settings of other YAM components.

Description (last modified by damato)

Nightly build 2009-09-25, OS3

The ARexx command LISTFREEZE MAILS does not freeze the mail list anymore (newer mails added are shown, as well as selections).

Also, there is a race problem with ARexx scripts, the MAILSTATUS command, and the "auto mark-as-read" feature. By the time the Arexx script make a mail current with SETMAIL, change its status to - lets' say - "U" (unread), and finish doing something with the current mail before making another mail current, the mail that was marked as unread is then marked as read by the auto mark timeout (thus 'sabotaging' the MAILSTATUS U command). I suggest that the 'LISTFREEZE MAILS' command also inhibit the "auto mark-as-read" behavior until a 'LISTUNFREEZE MAILS' command is reached.


Moved from SF:
https://sourceforge.net/tracker/?func=detail&aid=2868380&group_id=13560&atid=113560

Attachments (2)

debug.log (13.4 KB) - added by damato 5 years ago.
Debug output with the REXX flag, running SpamFryer.yam script - Moved from SF. Original author: amigaphil
testmove.rexx (1.4 KB) - added by AmigaPhil 5 years ago.
ARexx test script

Download all attachments as: .zip

Change History (18)

Changed 5 years ago by damato

Debug output with the REXX flag, running SpamFryer.yam script - Moved from SF. Original author: amigaphil

comment:1 Changed 5 years ago by damato

Nightly build 2009-09-30, OS3

Experimenting with a new SpamFryer.yam (spam filter), I discovered that LISTFREEZE MAILS does work, but some ARexx commands DO resect the frozen status of the mail list. Checking for spam, the mail list remain frozen until a spam is moved to the Trash folder (MAILMOVE). Then, all other mail checked are shown in the mail list, and displayed in the mail preview window.

While in frozen state, it seems that the auto mark-as-read behavior is inhibited as expected (I found no mails with a Read status where the status should have been Unread or New); but it's no more true when a command "unlock" the frozen status.

I think that the commands that "turn off" the LISTFREEZE frozen state of the mail list are: MAILMOVE, MAILSTATUS, and probably MAILCOPY, MAILDELETE.


Moved from SF. Original poster: amigaphil

comment:2 Changed 5 years ago by damato

Nightly build 2009-09-30, OS3

WEIRD...

I just had a YAM session, with SpamFryer.yam as 'After getting mails' event. 64 new mails were downloaded, 13 were spams. After the first moved-to-Trash spam, only the mail list window was unlocked (but that's fine, as it is showing which mail is currently being scanned). The checked mail was not rendered in the mail preview window, and was not loosing its 'New' status (marked as 'Read' while being selected/scanned).

?!? (I'll do some more tests.)


Moved from SF. Original poster: amigaphil

comment:3 Changed 5 years ago by damato

Nightly build 2009-09-30, OS3

Testing again today...

Downloaded 24 mails, 7 were spams.
All went fine until the first spam was moved to Trash (MAILMOVE). Then
each other scanned mail (SETMAIL) were shown in the mail list window,
displayed in the mail preview window, and eventually marked as read (when
it took longer for a mail to be checked).

?? :-(


Moved from SF. Original poster: amigaphil

comment:4 Changed 5 years ago by damato

I've uploaded here a new beta version of SpamFryer.yam (originally created by Allan Rasmussen) for testing this issue.

If you are new to SpamFryer, you might want to download the SpamFryer package by Simon N. Goodwin from Aminet first, so that you will have full documentation and a base keepList (white list) and loseList (black list) to work with. You also will need to edit the file to change (at least) the path to the keepList and loseList.

Suggested usage for testing (taken from the .readme):

If you want SpamFryer.yam to automatically check all new mails, then start YAM (this example assumes version 2.5), open the Settings/Configuration menu (or press the Right Amiga key and the asterisk in the top right corner of the numeric pad at the same time), click on 'Scripts' in the left column and select the line marked 'After getting mail' in the 'Action (Name)' column that appears under the heading 'Scripts settings'. Name will then be ghosted; ensure that the cycle gadget alongside says 'ARexx' not 'AmigaDOS' and enter:

YAM:Rexx/SpamFryer.yam Incoming SILENT

on the following line, by the caption 'Script'. Make sure that the two checkboxes below are both ticked:

[v] Open console window [v] Wait for termination


Moved from SF. Original poster: amigaphil

comment:5 Changed 5 years ago by damato

Here is a debug output with the flag set to REXX.

New mails 66 to 61 were checked, mail 64 was a spam and MAILMOVEd to Trash.

I don't see much that talk to me there, except those Timer.c:164:timer[4]: already stopped Timer.c:164:timer[3]: already stopped happening just after the MAILMOVE action and also when the other mail (63 to 61) are being processed.

(Note: I'm using the 'empty' theme, and thus, I removed almost all the imagecache warning messages.)

(Note2: Sorry if multiple post. Seems SourceForge has some problems right now.)


Moved from SF. Original poster: amigaphil

comment:6 Changed 5 years ago by damato

(Removed the SpamFryer.yam file as outdated. A newer version will appear
on Aminet soon.)


Moved from SF. Original poster: amigaphil

comment:7 Changed 5 years ago by damato

  • Priority changed from major to undecided
  • Severity set to major

comment:8 Changed 5 years ago by damato

  • Component changed from nightly build to ARexx interface

comment:9 Changed 5 years ago by damato

  • Cc yamos-svn@… removed

comment:10 Changed 5 years ago by damato

  • Reporter changed from amigaphil@… to AmigaPhil

comment:11 follow-up: Changed 5 years ago by damato

  • Status changed from new to pending

Is that problem still valid? If so please provide a step-by-step example on how to reproduce it.

Changed 5 years ago by AmigaPhil

ARexx test script

comment:12 Changed 5 years ago by AmigaPhil

  • Status changed from pending to new

Attachment (testmove.rexx) added by ticket reporter.

comment:13 in reply to: ↑ 11 Changed 5 years ago by AmigaPhil

Replying to damato:

Is that problem still valid? If so please provide a step-by-step example on how to reproduce it.

I've uploaded a new script for testing this.
It scans all messages in the current folder, and if one has the string "test" in subject, it is moved to the Trash folder.

The GUI remain quiet (as expected) until there is a match (a message is MAILMOVEd). Then the LISTFREEZE has no more effect (the GUI is refreshed for all other scanned mails).

comment:14 Changed 18 months ago by damato

  • Description modified (diff)
  • Milestone set to YAM 2.9
  • Owner changed from somebody to damato
  • Status changed from new to assigned

comment:15 Changed 16 months ago by damato

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [6975]) * mui/MainMailListGroup.c, rexx/listfreeze, rexx/listunfreeze.c: fixed the

LISTFREEZE and LISTUNFREEZE arexx command to make sure that no other internal
process which will use MUIA_NList_Quiet will suddenly unfreeze a list in
case the arexx command previously freezed it. Now a LISTUNFREEZE command is
mandatory or the mail list will never return from a quiet state. This finally
fixes a long standing issue and finally closes #12.

comment:16 Changed 12 months ago by damato

  • Release Notes modified (diff)

Add Comment

Modify Ticket

Action
as closed The owner will remain damato.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.

This list contains all users that will be notified about changes made to this ticket.

These roles will be notified: Reporter, Owner, Subscriber

  • Jens Maus(Owner, Participant)
  • Philippe Duchenne(Reporter, Participant)