close
Comments you submit will be routed for moderation. If you have an account, please log in first.
Modify

Opened 4 years ago

Closed 3 years ago

Last modified 2 years ago

#129 closed task (worksforme)

Review all function argument to use 'const' if possible.

Reported by: damato Owned by:
Priority: high Milestone: YAM 2.7
Component: coding/memory Version:
Severity: minor Keywords:
Cc: OS Platform:
Blocked By: Blocking:
Release Notes:

Description

According to make YAM more secure, especially in upcoming multitasking handling, it would be usefull to review all function arguments of all functions if they may be changed to contain the 'const' qualifier so that the compiler warns in case a change may affect the content of an argument.

Attachments (0)

Change History (4)

comment:1 Changed 4 years ago by damato

  • Status changed from new to accepted

comment:2 Changed 4 years ago by damato

  • Blocking 120 removed

comment:3 Changed 3 years ago by tboeckel

  • Resolution set to worksforme
  • Severity changed from major to minor
  • Status changed from accepted to closed

From my point of view this ticket is fulfilled. Although the "const" keywords is not used for all functions where it could be used, but I think most functions make use of it whenever it is possible.

If this ticket is to be fulfilled 100% then it will never be closed, because future functions may be implemented without "const" in the first place and thus we would have to reopen this one over and over again.

So better keep in mind to add "const" at as much places as possible. If this forgotten too easily then perhaps this should be noted in the STYLEGUIDE.

Closing this as "works for me", because there is no better suiting description.

comment:4 Changed 2 years ago by damato

  • Component changed from undefined to coding/memory

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.

This list contains all users that will be notified about changes made to this ticket.

These roles will be notified: Reporter, Owner, Subscriber

  • Jens Maus(Reporter, Participant)