close
Comments you submit will be routed for moderation. If you have an account, please log in first.
Modify

Opened 4 years ago

Closed 4 years ago

#138 closed enhancement (fixed)

Improve Birthday checking

Reported by: opiopi Owned by: tboeckel
Priority: low Milestone: YAM 2.7
Component: addressbook Version: 2.6
Severity: minor Keywords:
Cc: OS Platform:
Blocked By: Blocking:
Release Notes:

Description

Hi

For users like me who sometimes run YAM without a restart
it might be very important to rework the Birthday checking
function in YAM so that YAM check the birthday if a new day
is beginning. It could be done in the follow way.

At startup remember the current (old) day.
Call AB_CheckBirthdates() (like now).
Calculate the time until the next day (maybe add some seconds).
Run a Birthday timer with the calculated time.

If the timer triggers then check if old day <> current day and
only if both are different then Call AB_CheckBirthdates()

remember the current (nowold) day.
Calculate the time until the next day (maybe add some seconds).
run a Birthday timer with the calculated time.

In this way the user should not get a reminder twice also if
he change the time or date while YAM is running.

The only remaining issue is that we get the reminder one hour to
late if the DST is changed forward but it happen only once a year.

BTW: you should change some comments in Timer.c. Search for "idn"
and change it to "ion"...

Attachments (0)

Change History (4)

comment:1 Changed 4 years ago by damato

  • Milestone set to YAM 2.7
  • Priority changed from undecided to low
  • Severity changed from major to minor
  • Status changed from new to accepted

comment:2 Changed 4 years ago by damato

  • Reporter changed from Opi to opiopi

comment:3 Changed 4 years ago by tboeckel

  • Owner set to tboeckel
  • Status changed from accepted to assigned

comment:4 Changed 4 years ago by tboeckel

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [4601]) * YAM_AB.c, YAM.c, Timer.c: birthdays are now checked on a regular basis. This

means that YAM will automatically check for pending birthdays at 00:01 each
day if it is running over midnight. Let's see what the users think of this.
Maybe we need a configurable time for this check instead of the fixed 00:01.
This closes #138.

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.

This list contains all users that will be notified about changes made to this ticket.

These roles will be notified: Reporter, Owner, Subscriber

  • Frank Weber(Reporter)
  • Thore Böckelmann(Owner, Participant)