close
Comments you submit will be routed for moderation. If you have an account, please log in first.
Modify ↓

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#2 closed bug (fixed)

EOL char deleted when re-editing message

Reported by: stevebow@… Owned by: thboeckel
Priority: undecided Milestone: YAM 2.6p1
Component: user interface Version: 2.5
Severity: major Keywords: SF
Cc: Blocked By:
Blocking:
Release Notes:

Description (last modified by damato)

When you edit a message in the Outgoing folder, the very last EOL char is deleted.

For example, start a new message, then after the sig press <Enter> several times, then Hold the message.

Edit that message (now in Outgoing) and the very last EOL is gone. Hold and Edit again, and once more the last EOL is gone. This continues until the last EOL char is gone, but any ASCII (such as the sig itself) is not affected.

I have tried this with SimpleMail but the problem is not present, so it appears to be an issue with YAM and not TextEditor.

Using YAM 24/3/06 and TextEditor.mcc 15.17, OS4/A1XE.

Moved from SF:
​https://sourceforge.net/tracker/?func=detail&aid=1464538&group_id=13560&atid=113560

Attachments (0)

Change History (18)

comment:1 Changed 3 years ago by damato

Rather than opening a new bug, I'll reopen this one as the fix to this bug
has created another.

The problem is now the opposite. When you re-edit a held message, an EOL
char is now added.

Moved from SF. Original poster: stevebow

comment:2 Changed 3 years ago by damato

Ok, the issue should now hopefully be fixed once and for
all. So please grab the next nightly build and verify that
the problem is gone.

Moved from SF. Original poster: damato

comment:3 Changed 3 years ago by damato

Almost there.

If a held message has no attachment, the bug can be considred fixed. But
if there is already an attachment an EOL is still being added to the
message body in the write window.

Using the 27/4/06 build.

Moved from SF. Original poster: stevebow

comment:4 Changed 3 years ago by damato

Is the issue still persistent with the latest YAM nightly?
Please retry again.

Moved from SF. Original poster: damato

comment:5 Changed 3 years ago by damato

Yes it is. Using the 9/06/2006 nightly build and TextEditor 15.17.

Moved from SF. Original poster: stevebow

comment:6 Changed 3 years ago by damato

Ok. now I think I should have addressed really all kind of
incarnations of this bug. So please check the next upcoming
nightly build and try to reproduce each single observation
you had once again please. Let me know if everything seems
to work now as expected. I really hope that issue is now
resolved for forever...

Moved from SF. Original poster: damato

comment:7 Changed 3 years ago by damato

Do you want the good news or the bad news? ;)

The good news is that you've fixed the problem of EOLs being added when
rediting messages (and attached text files getting EOLs too).

The bad news is, you've introduced a new problem.

Do this:

  1. Start a new message, enter name/subject.
  2. Do not add any text to the message body (important), just leave the

sig.

  1. Attach a text file eg. S:startup-sequence.
  2. Hold this message.
  3. In the Outgoing folder, hilite and edit/read this message.

Here, I get the following error message:

Unexpected EOF while decoding multipart message. The message seems to be
truncated.

The sig is not displayed nor is the attachment.

Additionally, one e-mail I have received with a video/mpeg attachment also
displays this error. The attachment icon claims it is a 0 byte plain text
attachment. I can send you this entire message privately if you wish.

As this is related, I'll not close this bug.

Moved from SF. Original poster: stevebow

comment:8 Changed 3 years ago by damato

Oh damn, I really shouldn't code that quickly after
midnight. Thanks for finding the issue so quickly. I already
fixed it so please wait until the next nightly to appear and
then please trey to reproduce all of the issues in that LONG
bugreport after another and verify please that all things
are working fine now so that I can close that damn ticket :)

thanks again for all your help and great bug reports!

Moved from SF. Original poster: damato

comment:9 Changed 3 years ago by damato

Yes, you appear to have squashed that bug for real this time :).
I have tried the various combinations of this bug and things now work as
expected. Thanks.

Moved from SF. Original poster: stevebow

comment:10 Changed 3 years ago by damato

I've re-opened this as the problem has re-appeared (1/12/2008 build).
Trailing EOL chars are deleted when a held message is re-edited.

I suspect this has something to do with the recent bugfix #2349683.

Moved from SF. Original poster: stevebow

comment:11 Changed 3 years ago by damato

  • Priority changed from major to undecided
  • Severity set to major

comment:12 Changed 3 years ago by damato

  • Component changed from nightly build to undefined

comment:13 Changed 3 years ago by damato

  • Cc yamos-svn@… removed

comment:14 Changed 3 years ago by damato

  • Component changed from undefined to user interface
  • Status changed from new to pending

Would you please state if this problem really still exists with either the latest release 2.6 version or even the latest 2.7 nightly build? Thanks.

comment:15 Changed 3 years ago by thboeckel

  • Owner changed from somebody to thboeckel
  • Status changed from pending to assigned

comment:16 Changed 3 years ago by thboeckel

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [4593]) * YAM_RE.c: reading a message part will now correctly add the LF character

which was stripped by the GetLine() function. This fixes #2.

comment:17 Changed 3 years ago by thboeckel

  • Milestone set to YAM 2.7

comment:18 Changed 3 years ago by damato

  • Description modified (diff)
  • Milestone changed from YAM 2.7 to YAM 2.6p1

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.

This list contains all users that will be notified about changes made to this ticket.

These roles will be notified: Reporter, Owner, Subscriber

  • stevebow@…(Reporter)
  • Thore Böckelmann(Owner, Participant)