close
Comments you submit will be routed for moderation. If you have an account, please log in first.
Modify

Opened 21 months ago

Closed 21 months ago

Last modified 16 months ago

#375 closed bug (fixed)

Duplication of emails in Drafts.

Reported by: Lemen Owned by:
Priority: undecided Milestone: YAM 2.8p1
Component: user interface Version: nightly build
Severity: major Keywords:
Cc: OS Platform:
Blocked By: Blocking:
Release Notes:

fixed some problems with the new Drafts folder managment where emails could end up duplicated. In addition, the 'Hold' button has been renamed to 'Save to Drafts' to better differentate between the operations.

Description

AmigaONE XE / OS4.1u6 / YAM 2.9 dev 15/01/2013 (GCC 4.7.1, r6514).

Open an email in the "Outgoing" folder and click "Hold", this creates a duplicate email in the "Drafts" folder. Everytime you do this, another duplicate will be created in "Drafts".

Surely, the email should be MOVED from "Outgoing" into "Drafts" when the "Hold" button is clicked rather than COPIED? Similar to when you create an email in "Drafts" and click "Send later" ?

Attachments (0)

Change History (7)

comment:1 Changed 21 months ago by Lemen

  • Milestone set to YAM 2.8p1

comment:2 Changed 21 months ago by damato

  • Milestone YAM 2.8p1 deleted

Would you please refrain from modifying ticket properties. It is up to the developers to decide to which milestone a ticket belongs.

comment:3 Changed 21 months ago by tboeckel

  • Milestone set to YAM 2.8p1
  • Status changed from new to accepted

Your objection is a good one. But Jens and me just had a longer discussion about this situation and we came to the conclusion that moving a mail from Outgoing to Drafts before editing it again is no viable solution either. The point is that immediately after the move one could click on "Cancel". What should happen to the mail then? Leaving it in Drafts is wrong, because it should be in Outgoing again, because canceling something should restore the former situation? But what if the mail has been modified and saved automatically in the meantime? Moving the mail back to Outgoing would not restore the former mail. It would be a different one.

We finally came to this conclusion. Double clicking a mail in Outgoing will no longer open an edit window, but will simply just show this mail as for any other type of folder. Currently we already have the menu items "Edit as new" and "Change/Modify", but right now the situation in which they are available is wrong: "Edit as new" appears for the Drafts folder and "Change/Modify" appears for the the Outgoing folder. This must be swapped. Furthermore the write window's "Hold" button should be renamed to "Save" and leave the write window open when clicked. Thus choosing "Edit as new" in Outgoing will leave the mail as it is and start editing a new mail with the same content. Sending this new mail (either immediately or later) will create another mail in Outgoing. The user will have to delete the old mail from Outgoing manually. However, this ensures that clicking "Cancel" will have the desired and correct effect, no matter when this is done. Finally the philosophy for Outgoing is slightly changed in such a way that Outgoing really contains mails only which are considered "finished". Finished things should not be modified anymore, otherwise they could not have been "finished" in the first place. "Unfinished" stuff belongs to Drafts, as the name suggests.

Although this means a break in YAM's known behaviour we think that this changed behaviour makes YAM more consistent.

comment:4 Changed 21 months ago by tboeckel

(In [6521]) * YAM_MA.c, YAM_WR.c, mui/MainMailList.c, mui/ReadWindow.c: swapped the edit menu item titles for the Drafts and Outgoing folders. Mails in drafts can be edited directly and mails in Outgoing can only be edited "as new" like in any other folder. This partly addresses and refs #375.

comment:5 Changed 21 months ago by tboeckel

(In [6522]) * misc: removed all references to the old HOLD and QUEUED states. These states are now implied by a mail's folder (Drafts or Outgoing). This refs #375.

comment:6 Changed 21 months ago by tboeckel

  • Resolution set to fixed
  • Status changed from accepted to closed

(In [6528]) * mui/WriteWindow.c: renamed the "Hold" button/menu item to "Save as draft" as this is what these objects really do. Furthermore the write window is no longer closed in this situation, because saving a mail as draft means that the mail is not yet finished and the user might want to continue to work on it immediately. Finally the Cancel button has been removed as canceling the edit action can be done by closing the window or choosing "Close" from the menu or by pressing the window close key (usually ESC). This finally closes #375.

comment:7 Changed 16 months ago by damato

  • Release Notes modified (diff)

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.

This list contains all users that will be notified about changes made to this ticket.

These roles will be notified: Reporter, Owner, Subscriber

  • Lee M Hemenway(Reporter, Participant)