close
Comments you submit will be routed for moderation. If you have an account, please log in first.
Modify

Opened 3 months ago

Closed 3 months ago

Last modified 3 months ago

#545 closed bug (fixed)

Crash in Configuration/Signature

Reported by: Raziel Owned by: tboeckel
Priority: normal Milestone: YAM 2.10
Component: coding/memory Version: 2.9p1
Severity: major Keywords:
Cc: OS Platform: AmigaOS4
Blocked By: Blocking:
Release Notes:

fixed a wrong pointer handling for signatures causing a crash.

Description

Summary

If you copy something (anything) into the "Signature text" field while it's not in use and leave it there while cancelling the changes YAM will crash

Steps to reproduce

  1. Open Notepad or any other text based program
  2. Enter anything...like dkjgbjdshngjksödhgiösihdsf
  3. Mark what you typed
  4. Right-Amiga + C it (copy to Clipboard)
  5. In YAM go to Config/Signature

My signature tab looks like this:

Signatures:
Default Signature

Signature:
Active - Checked

Description:
Default Signature

Signature Text:
Completely empty
All three buttons beneath the Signature text are greyed out
Append a file as signature instead: Checked
Path to the signature file

  1. Now click once into the "Description" field underneath the "Active" checkmark (a cursor should be visible now behind the text "Default signature")
  2. Press the TAB key (you'll see a border appear underneath around the "Description" field when it gets activated)
  3. Press Right-Amiga + V to paste your Clipboard text here
  4. The last step is to click on "Cancel" and then on "Close Window" and it crashes

Expected results

No crash and probably no possibility to activate the "Signature text" field using TAB when it's not meant to be in use

Actual results

The possibility to activate and paste into the "Signature text" filed while it's not in use and crashing YAM :-)

Regression

I have no idea if this is a regression as i never tried to do the above.

What i know is that it also happens in v2.9...i checked before updating

Notes

Hmm, notes, notes...ah, ok

Thank you for the very best eMail program on every platform out there :-)

Attachments (2)

Crashlog_YAM_2014-04-19_09-24-56.txt (35.6 KB) - added by Raziel 3 months ago.
Crashlog_YAM_2014-04-19_09-19-27.txt (35.9 KB) - added by Raziel 3 months ago.
This is a crashlog created with YAM2.9

Download all attachments as: .zip

Change History (6)

Changed 3 months ago by Raziel

Changed 3 months ago by Raziel

This is a crashlog created with YAM2.9

comment:1 Changed 3 months ago by Raziel

Step 7 should of course be

  1. Press the TAB key (you'll see a border appear underneath around the "Signature text" field when it gets activated)

comment:2 Changed 3 months ago by tboeckel

  • Component changed from configuration to coding/memory
  • Milestone set to YAM 2.10
  • Owner set to tboeckel
  • Priority changed from undecided to normal
  • Status changed from new to assigned

comment:3 Changed 3 months ago by tboeckel

  • Resolution set to fixed
  • Status changed from assigned to closed

In 7807:

  • mui/SignatureTextEdit.c: getting a modified signature text from the editor object must treat the destination string as a dynamically allocated string. Otherwise a crash will happen when the string is finally freed. This closes #545.

comment:4 Changed 3 months ago by tboeckel

  • Release Notes modified (diff)

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.

This list contains all users that will be notified about changes made to this ticket.

These roles will be notified: Reporter, Owner, Subscriber

  • Hubert Maier(Reporter, Participant)
  • Thore Böckelmann(Owner, Participant)